release: Update go modules for pre-release #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wainersm
reviewed
Jul 1, 2024
src/cloud-api-adaptor/go.mod
Outdated
| @@ -47,8 +47,8 @@ require ( | |||
| github.com/aws/aws-sdk-go-v2/service/eks v1.29.5 | |||
| github.com/aws/aws-sdk-go-v2/service/iam v1.22.5 | |||
| github.com/aws/aws-sdk-go-v2/service/s3 v1.38.5 | |||
| github.com/confidential-containers/cloud-api-adaptor/src/cloud-providers v0.8.2 | |||
| github.com/confidential-containers/cloud-api-adaptor/src/peerpod-ctrl v0.8.2 | |||
| github.com/confidential-containers/cloud-api-adaptor/src/cloud-providers v0.9.0-alpha0 | |||
There was a problem hiding this comment.
This the "alpha" usage problem that you mentioned on last meeting? i.e., caa always tagged <version>-alphaN but now <version> is actually an alpha release too!
If so, would make sense to call it v0.9.0-alpha1-alpha0? I confess this seems ugly and I never saw such as versioning before...but just in case, let me ask :)
There was a problem hiding this comment.
I considered that myself, but thought it was ugly. If it occured to you then it's probably worth switching :)
We are working on the `v0.9.0-alpha1` pre-release, so bump the go modules to use the new tag we will create once they are merged. Due to the pre-release of an alpha the version looks messy, but we will improve it soon Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
force-pushed
the
0.9.0-alpha1-pre-release-go-module-bump
branch
from
d503d88 to
dffbe03
Compare
wainersm
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working on the
v0.9.0-alpha1pre-release, so bump the go modules to use the new tag we will create once they are merged.